Add 1.0 release to wording in CONTRIBUTING #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, agree. We definitely don't want to encourage adding middleware to Maybe we should think of some sort of review process and consequent addition to an official "middleware/adapters marketplace"? You know, to give these external projects some visibility |
|
@iMacTia I changed some wording. This is an improvement, at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CONTRIBUTING document to reflect the fact that v1.0 has been released.
Unrelated: One thing that stood out to me was the policy of accepting new middleware. That seems like an outdated policy?
I came across this while preparing to copy content to the faraday-http project, to support lostisland/faraday-http#14